This repository has been archived by the owner on May 31, 2024. It is now read-only.
fix: Use ExtraHosts only for linux machines with native docker engine #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortalHappiness
requested review from
kumare3,
EngHabu and
wild-endeavor
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #461 +/- ##
==========================================
+ Coverage 67.69% 67.71% +0.02%
==========================================
Files 148 148
Lines 6639 6647 +8
==========================================
+ Hits 4494 4501 +7
- Misses 1855 1856 +1
Partials 290 290
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pingsutw
reviewed
Feb 14, 2024
MortalHappiness
force-pushed
the
bugfix/remove-non-native-linux-docker-extrahosts
branch
from
878526f
to
f88817d
Compare
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness
force-pushed
the
bugfix/remove-non-native-linux-docker-extrahosts
branch
from
f88817d
to
7c83a52
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Use ExtraHosts only for Linux machines with native docker engine
Type
Are all requirements met?
Complete description
Detect whether
/var/run/docker.sockis not a symbolic link and is a socket file. If true, add ExtraHosts. Otherwise, return empty ExtraHosts.Tracking Issue
None
Follow-up issue
NA